Re: few more wait events to add to docs

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jeremy Schneider <schnjere(at)amazon(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: few more wait events to add to docs
Date: 2019-03-07 13:59:44
Message-ID: 20190307135944.GB26628@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 07, 2019 at 11:25:10AM +0900, Michael Paquier wrote:
> On Wed, Mar 06, 2019 at 11:08:12AM -0800, Jeremy Schneider wrote:
>> If anything, I think we might just want to add comments to
>> RegisterLWLockTranches() and lwlocknames.txt with links to the doc file
>> that needs to be updated whenever a new tranche is added.
>
> Yes, that would surely help.
>
>> Not sure the best place for a comment on SLRUs (is SimpleLruInit a good
>> place?)... but I'm kindof hopeful that we're not adding many more new
>> SLRUs anyway and that people would bias toward leveraging the buffer
>> cache when possible.
>
> A reference at the top of SimpleLruInit() sounds good to me.

Thinking more about that, a comment at the top of SimpleLruInit() and
RegisterLWLockTranches() are both good things.

So please find attached a patch which does the following things to
address this thread:
- Reorder the list of events in the Lock section in alphabetical order
(not LWLock!).
- Add the missing event entries, which is what Thomas has provided.
- Add more documentation to mention the doc updates.

Thoughts?
--
Michael

Attachment Content-Type Size
wait-event-docs.patch text/x-diff 6.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-03-07 14:11:16 Re: pgsql: Removed unused variable, openLogOff.
Previous Message Robert Haas 2019-03-07 13:54:17 Re: Update does not move row across foreign partitions in v11