| From: | Shawn Debnath <sdn(at)amazon(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Refactoring the checkpointer's fsync request queue |
| Date: | 2019-03-05 16:07:15 |
| Message-ID: | 20190305160715.GA26468@f01898859afd.ant.amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 05, 2019 at 10:45:37PM +1300, Thomas Munro wrote:
> On Tue, Mar 5, 2019 at 2:25 PM Shawn Debnath <sdn(at)amazon(dot)com> wrote:
> > [v11 patch]
>
> Thanks. Hmm, something is wrong here because make check is
> dramatically slower -- for example the "insert" test runs in ~8-13
> seconds instead of the usual ~0.2 seconds according to Travis,
> AppVeyor and my local FreeBSD system (note that fsync is disabled so
> it's not that -- it must be bogus queue-related CPU?)
Confirmed. Patch shows 8900 ms vs 192 ms on master for the insert test.
Interesting! It's reproducible so should be able to figure out what's
going on. The only thing we do in ForwardSyncRequest() is split up the 8
bits into 2x4 bits and copy the FileTagData structure to the
checkpointer queue. Will report back what I find.
--
Shawn Debnath
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Perumal Raj | 2019-03-05 16:09:12 | Re: Question about pg_upgrade from 9.2 to X.X |
| Previous Message | Robert Haas | 2019-03-05 16:03:24 | Re: Question about commit 11cf92f6e2e13c0a6e3f98be3e629e6bd90b74d5 |