| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: pg_partition_tree crashes for a non-defined relation |
| Date: | 2019-03-01 00:22:04 |
| Message-ID: | 20190301002204.GA1348@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 28, 2019 at 04:32:03PM -0300, Alvaro Herrera wrote:
> Yeah, looks good, please push.
Done for this part.
> I would opt for returning the empty set for legacy inheritance too.
>
> More generally, I think we should return empty for anything that's
> either not RELKIND_PARTITIONED_TABLE or has relispartition set.
I think that one option is to make the function return only the table
itself if it is not a partitioned table, which would be more
consistent with what pg_partition_root() does.
What I am writing next sounds perhaps a bit fancy, but in my opinion a
normal table is itself a partition tree, made of one single member:
itself.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ramanarayana | 2019-03-01 00:36:17 | Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context |
| Previous Message | Michael Banck | 2019-03-01 00:05:14 | Re: Online verification of checksums |