Re: get_controlfile() can leak fds in the backend

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: get_controlfile() can leak fds in the backend
Date: 2019-02-28 00:54:45
Message-ID: 20190228005445.GC1617@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 27, 2019 at 07:45:11PM -0500, Joe Conway wrote:
> It seems to me that OpenTransientFile() is more appropriate. Patch done
> that way attached.

Works for me, thanks for sending a patch! While on it, could you
clean up the comment on top of get_controlfile()? "char" is mentioned
instead of "const char" for DataDir which is incorrect. I would
remove the complete set of arguments from the description and just
keep the routine name.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marc Dean 2019-02-28 01:01:16 Re: BUG #15293: Stored Procedure Triggered by Logical Replication is Unable to use Notification Events
Previous Message Andres Freund 2019-02-28 00:50:01 Re: get_controlfile() can leak fds in the backend