Re: pgsql: Use slots in trigger infrastructure, except for the actual invoc

From: Andres Freund <andres(at)anarazel(dot)de>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Use slots in trigger infrastructure, except for the actual invoc
Date: 2019-02-27 18:16:21
Message-ID: 20190227181621.xholonj7ff7ohxsg@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2019-02-27 12:59:16 -0500, Andrew Dunstan wrote:
>
> On 2/27/19 1:22 AM, Andres Freund wrote:
> > Hi,
> >
> > On 2019-02-27 04:41:28 +0000, Andres Freund wrote:
> >> Use slots in trigger infrastructure, except for the actual invocation.
> > Andrew, I see that this broke crake's redis_fdw check. I see it actually
> > fails with an error, rather than fail to build. Could you perhaps enable
> > generating backtraces?
>
>
> Not sure why it should fail to build.

Oh, because one of the options was that it used a slot from a variable
name that doesn't exist anymore...

> Backtraces should be enabled in the animal - I will investigate why
> we're not getting them here. Meanwhile, here's one for this problem:

Thanks, that helps! My first theories as to what's going on fell flat,
unfortunately. I guess I'll have to figure out how to run that locally
:(.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2019-02-27 23:30:49 pgsql: Remove unused macro
Previous Message Andrew Dunstan 2019-02-27 17:59:16 Re: pgsql: Use slots in trigger infrastructure, except for the actual invoc