| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Peter Geoghegan <pg(at)bowt(dot)ie>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: pg_regress: Don't use absolute paths for the diff |
| Date: | 2019-02-23 00:39:36 |
| Message-ID: | 20190223003936.GF6197@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Greetings,
* Michael Paquier (michael(at)paquier(dot)xyz) wrote:
> On Fri, Feb 22, 2019 at 03:26:35PM -0800, Andres Freund wrote:
> > that's useless, because I can't trivially copy the result file into the
> > expected file anymore. I have to figure out where in the tree it
> > is. Which isn't exactly predictable, between the different tests we
> > have as they locate their test results in different places.
>
> I haven't paid much attention to this commit, but the new behavior is
> likely something which will become annoying in some not-so-far future
> for me as well.
>
> > This is a bad idea.
>
> +1.
Yeah, same here, if I can't easily copy the result file into the
expected file, I'm going to be *most* annoyed...
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-02-23 08:42:18 | pgsql: Revert "pg_regress: Don't use absolute paths for the diff" |
| Previous Message | Michael Paquier | 2019-02-22 23:43:15 | pgsql: Fix incorrect function reference in comment of twophase.c |