Re: shared-memory based stats collector

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: alvherre(at)2ndquadrant(dot)com
Cc: andres(at)anarazel(dot)de, tomas(dot)vondra(at)2ndquadrant(dot)com, ah(at)cybertec(dot)at, magnus(at)hagander(dot)net, robertmhaas(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: shared-memory based stats collector
Date: 2019-02-21 07:05:55
Message-ID: 20190221.160555.191280262.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hello.

At Wed, 20 Feb 2019 15:45:17 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in <20190220(dot)154517(dot)24528798(dot)horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
> At Fri, 15 Feb 2019 15:53:28 -0300, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote in <20190215185328(dot)GA29663(at)alvherre(dot)pgsql>
> > Talk about moving the whole file to another subdir ...
>
> Sounds reasonable. It was a searate patch at the first but
> currently melded to bloat the patch. I'm going to revert the
> separation/moving.

Done. This verison 16 looks as if the moving and splitting were
not happen. Major changes are:

- Restored old pgstats_* names. This largily shrinks the patch
size to less than a half lines of v15. More than that, it
gets easier to examine differences. (checkpointer.c and
bgwriter.c have a bit stale comments but it is an issue for
later.)

- Removed "oneshot" feature at all. This simplifies pgstat API
and let this patch far less simple.

- Moved StatsLock to LWTRANCHE_STATS, which is not necessary to
be in the main tranche.

- Fixed several bugs revealed by the shrinked size of the patch.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v16-0001-sequential-scan-for-dshash.patch text/x-patch 10.6 KB
v16-0002-Add-conditional-lock-feature-to-dshash.patch text/x-patch 5.0 KB
v16-0003-Make-archiver-process-an-auxiliary-process.patch text/x-patch 11.9 KB
v16-0004-Allow-dsm-to-use-on-postmaster.patch text/x-patch 1.2 KB
v16-0005-Shared-memory-based-stats-collector.patch text/x-patch 208.9 KB
v16-0006-Remove-the-GUC-stats_temp_directory.patch text/x-patch 10.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2019-02-21 07:09:33 RE: Timeout parameters
Previous Message Amit Kapila 2019-02-21 06:58:16 Re: WIP: Avoid creation of the free space map for small tables