BRIN summarize autovac_report_workitem passes datname as relname

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: BRIN summarize autovac_report_workitem passes datname as relname
Date: 2019-02-20 18:55:52
Message-ID: 20190220185552.GR28750@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

src/backend/postmaster/autovacuum.c declares:

|static void
|autovac_report_workitem(AutoVacuumWorkItem *workitem,
| const char *nspname, const char *relname)

But calls it like:

| cur_relname = get_rel_name(workitem->avw_relation);
| cur_nspname = get_namespace_name(get_rel_namespace(workitem->avw_relation));
| cur_datname = get_database_name(MyDatabaseId);
| if (!cur_relname || !cur_nspname || !cur_datname)
| goto deleted2;
|
| autovac_report_workitem(workitem, cur_nspname, cur_datname);

So I see stuff like:

|check_pg - txn_time POSTGRES_TXN_TIME OK: DB main longest txn: 164s PID:10697 database:main username: query:autovacuum: BRIN summarize public.main 1028223

I guess it should be database.namespace.relname ?

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Verite 2019-02-20 19:12:18 Re: Compressed TOAST Slicing
Previous Message Paul Ramsey 2019-02-20 18:55:19 Re: Compressed TOAST Slicing