Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, vladimirlesk(at)yandex-team(dot)ru, dsarafan(at)yandex-team(dot)ru
Subject: Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line
Date: 2019-02-18 16:49:02
Message-ID: 20190218164902.GA7979@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2019-Feb-18, Andres Freund wrote:

> Hi,
>
> On 2019-02-18 16:26:55 +0300, Alexey Kondratov wrote:
> > Hi Andres,
> >
> > Thank you for your feedback.
> >
> > On 16.02.2019 6:41, Andres Freund wrote:
> > > It sounds like a seriously bad idea to use a different parser for
> > > pg_rewind. Why don't you just use postgres for it? As in
> > > /path/to/postgres -D /path/to/datadir/ -C shared_buffers
> > > ?

Eh, this is what I suggested in this thread four months ago, though I
didn't remember at the time that aaa6e1def292 had already introduced -C
in 2011. It's definitely the way to go ... all this messing about with
the parser is insane.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2019-02-18 16:59:22 Re: 2019-03 CF Summary / Review - Tranche #2
Previous Message Michael Banck 2019-02-18 16:44:50 Re: Progress reporting for pg_verify_checksums