Re: Progress reporting for pg_verify_checksums

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Banck <michael(dot)banck(at)credativ(dot)de>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Bernd Helmle <bernd(dot)helmle(at)credativ(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Progress reporting for pg_verify_checksums
Date: 2019-02-18 14:18:26
Message-ID: 20190218141826.GA3173@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Feb-17, Michael Banck wrote:

> + /*
> + * As progress status information may be requested, we need to scan the
> + * directory tree(s) twice, once to get the idea how much data we need to
> + * scan and finally to do the real legwork.
> + */
> + total_size = scan_directory(DataDir, "global", true);
> + total_size += scan_directory(DataDir, "base", true);
> + total_size += scan_directory(DataDir, "pg_tblspc", true);

Surely we know at that point whether this first scan is needed, and we
can skip it if not?

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2019-02-18 14:21:11 Re: Problems with plan estimates in postgres_fdw
Previous Message Peter Eisentraut 2019-02-18 13:58:09 Re: libpq environment variables in the server