| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Fetter <david(at)fetter(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, pgsql-hackers(at)postgresql(dot)org, daniel(at)yesql(dot)se, michael(at)paquier(dot)xyz |
| Subject: | Re: Synchronize with imath upstream |
| Date: | 2019-02-16 19:10:21 |
| Message-ID: | 20190216191021.GC1212026@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 07, 2019 at 11:56:18PM -0500, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > On Thu, Feb 07, 2019 at 10:12:05AM -0500, Tom Lane wrote:
> >> I have no particular opinion on whether pgindent should be part of the
> >> mix for imath, but I do strongly recommend setting up and documenting a
> >> reproducible import process, as I did for src/timezone.
>
> > Good idea. I've modified the imath.c header comment to take the form of an
> > import process; see attached imath1.29-pgedits-v2.patch.
>
> Maybe easier to keep the instructions in a separate README file?
Most imath.c patches have cause to update those lines, and patches to other
files almost never do. Hence, I think hackers are more likely to find and
update those lines in imath.c. I would choose a README if concerns weren't
concentrated in one file.
> (I don't see a need to put a PG copyright in this file, when the
> mods from upstream are this small.)
The tree has been inconsistent about that, which is okay. I was mimicking
src/port/strlcpy.c. Others, e.g. src/port/crypt.c, haven't added a copyright.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-02-16 19:12:50 | Re: Synchronize with imath upstream |
| Previous Message | John Naylor | 2019-02-16 15:50:51 | Re: automatically assigning catalog toast oids |