| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Paul Ramsey <pramsey(at)cleverelephant(dot)ca> |
| Cc: | rafia(dot)sabih(at)enterprisedb(dot)com, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Compressed TOAST Slicing |
| Date: | 2019-02-16 02:25:50 |
| Message-ID: | 20190216022550.s27i2dxqweym27cr@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Stephen,
On 2018-12-06 12:54:18 -0800, Paul Ramsey wrote:
> On Sun, Dec 2, 2018 at 7:03 AM Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>
> wrote:
> >
> > The idea looks good and believing your performance evaluation it seems
> > like a practical one too.
>
> Thank you kindly for the review!
>
> > A comment explaining how this check differs for is_slice case would be
> helpful.
> > Looks like PG indentation is not followed here for n.
>
> I have attached updated patches that add the comment and adhere to the Pg
> variable declaration indentation styles,
> ATB!
> P
You were mentioning committing this at the Brussels meeting... :)
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-02-16 02:36:18 | Re: 2019-03 CF Summary / Review - Tranche #1 |
| Previous Message | Andres Freund | 2019-02-16 02:22:54 | Re: Delay locking partitions during INSERT and UPDATE |