| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Arseny Sher <a(dot)sher(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Lakhin <a(dot)lakhin(at)postgrespro(dot)ru> |
| Subject: | Re: Too rigorous assert in reorderbuffer.c |
| Date: | 2019-02-11 18:50:03 |
| Message-ID: | 20190211185003.GA27084@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Feb-07, Arseny Sher wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Ah, okay. Does the test still fail when run without the code fix?
>
> Yes. The problem here is overriding cmax of catalog (pg_attribute in the
> test) tuples, so it fails without any data at all.
Makes sense.
I thought the blanket removal of the assert() was excessive, and we can
relax it instead; what do you think of the attached?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Remove-assertion-in-reorderbuffer-that-cmax-is-stabl.patch | text/x-diff | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-02-11 18:58:01 | Re: PG_RE_THROW is mandatory (was Re: jsonpath) |
| Previous Message | Lætitia Avrot | 2019-02-11 17:44:41 | Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance |