Re: Tighten up a few overly lax regexes in pg_dump's tap tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Tels <nospam-pg-abuse(at)bloodgate(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Tighten up a few overly lax regexes in pg_dump's tap tests
Date: 2019-02-08 00:04:46
Message-ID: 20190208000446.GA19742@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 07, 2019 at 03:33:54PM +0100, Daniel Gustafsson wrote:
> Correct. The idea was to maintain readability while making the regex a bit
> better, without any claims to make it perfect.

Agreed with your position. I see no point is making all the
expressions unreadable for little gain. What Daniel proposed upthread
had a better balance in my opinion than the previous behavior, without
sacrifying the readability of anything and still improving the error
detection.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-02-08 00:07:57 Re: Add pg_partition_root to get top-most parent of a partition tree
Previous Message Robbie Harwood 2019-02-07 23:55:24 Re: Commit Fest 2019-01 is now closed