| From: | David Fetter <david(at)fetter(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Tighten up a few overly lax regexes in pg_dump's tap tests |
| Date: | 2019-02-07 17:20:47 |
| Message-ID: | 20190207172046.GK10435@fetter.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 07, 2019 at 10:10:32AM +0900, Michael Paquier wrote:
> On Wed, Feb 06, 2019 at 03:41:20PM +0100, Daniel Gustafsson wrote:
> > Correct. One could argue that the regex is still suboptimal since “COMMENT ON
> > DATABASE postgres IS ;” will be matched as well, but there I think the tradeoff
> > for readability wins.
>
> Okay, that looks like an improvement anyway, so committed after going
> over the tests for similar problems, and there was one for CREATE
> DATABASE and DROP ROLE. It is possible to have a regex which tells as
> at least one non-whitespace character, but from what I can see these
> don't really improve the readability.
Are you talking about \w+, or [^[:space:]]+, [^[:blank:]]+, or...?
Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2019-02-07 17:43:25 | Re: ToDo: show size of partitioned table |
| Previous Message | Antonin Houska | 2019-02-07 17:04:48 | Re: Problems with plan estimates in postgres_fdw |