Re: Location of pg_rewind/RewindTest.pm and ssl/ServerSetup.pm

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Location of pg_rewind/RewindTest.pm and ssl/ServerSetup.pm
Date: 2019-02-07 01:44:59
Message-ID: 20190207014458.GE4074@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 06, 2019 at 08:34:11PM -0500, Andrew Dunstan wrote:
> The obvious solution is to perform the same surgery for the ssl and
> pg_rewind tests that we performed for genbki.pl and other scripts, but
> in these cases the used modules are not in the same directory as the
> using scripts, but in their parent directories. I can't think of a good
> reason for this.They clearly relate to the TAP test suites, and nothing
> else, so it seems to me that they should go into the same directory as
> the TAP test scripts. There should be no danger that "prove" will try to
> run them, as it is only set up to run files with a ".pl" extension.
>
> While we're at it, I think ServerSetup.pm should possibly be renamed to
> something like SSLServer.pm (and the perl code adjusted accordingly)
>
> Does anyone object to me making these changes?

Not really if this eases the buildfarm coverage. At the same time, it
seems to me that it could be a good idea to install those sub-modules.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2019-02-07 01:47:19 Re: pg11.1: dsa_area could not attach to segment
Previous Message Andrew Dunstan 2019-02-07 01:34:11 Location of pg_rewind/RewindTest.pm and ssl/ServerSetup.pm