| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Arseny Sher <a(dot)sher(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Lakhin <a(dot)lakhin(at)postgrespro(dot)ru> |
| Subject: | Re: Too rigorous assert in reorderbuffer.c |
| Date: | 2019-02-06 16:30:50 |
| Message-ID: | 20190206163050.GA22952@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Feb-06, Arseny Sher wrote:
>
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>
> > note the additional pg_temp_XYZ row in the middle. This is caused by
> > the rewrite in ALTER TABLE. Peter E fixed that in Pg11 in commit
> > 325f2ec55; I don't think there's much to do in the backbranches other
> > than hide the pesky record to avoid it breaking the test.
>
> Oh, I see. Let's just remove the first insertion then, as in attached.
> I've tested it on master and on 9.4.
Ah, okay. Does the test still fail when run without the code fix?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-02-06 16:31:07 | Re: Don't deform column-by-column in composite_to_json |
| Previous Message | Andres Freund | 2019-02-06 16:28:24 | Re: Don't deform column-by-column in composite_to_json |