Re: [HACKERS] logical decoding of two-phase transactions

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Nikhil Sontakke <nikhils(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Sokolov Yura <y(dot)sokolov(at)postgrespro(dot)ru>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Date: 2019-02-04 05:15:04
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Jan 25, 2019 at 02:03:27PM -0300, Alvaro Herrera wrote:
> Eyeballing 0001, it has a few problems.
> 1. It's under-parenthesizing the txn argument of the macros.
> 2. the "has"/"is" macro definitions don't return booleans -- see
> fce4609d5e5b.
> 3. the remainder of this no longer makes sense:
> /* Do we know this is a subxact? Xid of top-level txn if so */
> - bool is_known_as_subxact;
> TransactionId toplevel_xid;
> I suggest to fix the comment, and also improve the comment next to the
> macro that tests this flag.
> (4. the macro names are ugly.)

This is an old thread, and the latest review is very recent. So I am
moving the patch to next CF, waiting on author.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-02-04 05:16:42 Re: amcheck verification for GiST
Previous Message Thomas Munro 2019-02-04 05:14:02 Re: Undo logs