| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, LAM JUN RONG <h1710074(at)nushigh(dot)edu(dot)sg>, Andreas 'ads' Scherbaum <ads(at)pgug(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improvements to "Getting started" tutorial for Google Code-in task |
| Date: | 2019-02-04 01:59:13 |
| Message-ID: | 20190204015913.GM1881@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 05, 2019 at 04:21:23PM +0100, Peter Eisentraut wrote:
> On 04/01/2019 00:05, Alvaro Herrera wrote:
>> Besides that, I have a hard time considering this patch committable.
>> There are some good additions, but they are mixed with some wording
>> changes that seem to be there just because the author doesn't like the
>> original, not because they're actual improvements.
>
> I agree. I don't find any of the changes to be improvements.
I have marked the patch as returned with feedback, as it has been
waiting input from the author for four weeks now.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-02-04 02:02:44 | Re: INSTALL file |
| Previous Message | Michael Paquier | 2019-02-04 01:56:43 | Re: Proposal for Signal Detection Refactoring |