| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Synchronize with imath upstream |
| Date: | 2019-02-03 08:11:24 |
| Message-ID: | 20190203081124.GC6226@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Feb 03, 2019 at 07:07:36AM +0000, Andrew Gierth wrote:
> In that case I propose that we avoid the whole issue by removing
> -Wdeclaration-after-statement entirely.
Some folks who skip $SUBJECT will be interested in your proposal. If you wish
to pursue that proposal, please start a new thread.
On Sun, Feb 03, 2019 at 07:14:13AM +0000, Andrew Gierth wrote:
> >>>>> "Noah" == Noah Misch <noah(at)leadboat(dot)com> writes:
>
> Noah> - # -Wdeclaration-after-statement isn't applicable for C++
> Noah> + # -Wdeclaration-after-statement isn't applicable for C++. Specific C files
> Noah> + # disable it, so AC_SUBST the negative form.
> Noah> + PERMIT_DECLARATION_AFTER_STATEMENT=
> Noah> + if test x"$save_CFLAGS" != "$CFLAGS"; then
>
> Missing "x" here?
>
> + if test x"$save_CFLAGS" != x"$CFLAGS"; then
I'll incorporate your fix. Thanks.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2019-02-03 08:14:44 | Re: Early WIP/PoC for inlining CTEs |
| Previous Message | Fabien COELHO | 2019-02-03 08:00:19 | Re: pg_dump multi VALUES INSERT |