Re: ArchiveEntry optional arguments refactoring

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Chapman Flack <chap(at)anastigmatix(dot)net>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ArchiveEntry optional arguments refactoring
Date: 2019-02-01 14:30:58
Message-ID: 201902011430.2cm3lirklmed@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2019-Feb-01, Dmitry Dolgov wrote:

> > On Fri, Feb 1, 2019 at 12:33 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:

> > > * Use NULL as a default value where it was an empty string before (this
> > > required few minor changes for some part of the code outside ArchiveEntry)
> >
> > I would rename the function to sanitize_line() and put those comments there
> > (removing them from the callsites), then the new argument I suggest would not
> > be completely out of place.
>
> Yes, sounds pretty reasonable for me.

Thanks for looking -- pushed.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-02-01 14:34:49 Re: Synchronous replay take III
Previous Message Robert Haas 2019-02-01 14:29:41 Re: Delay locking partitions during INSERT and UPDATE