Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
Date: 2019-01-31 00:44:51
Message-ID: 20190131004451.GE16781@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 30, 2019 at 02:41:01PM +0100, Christoph Berg wrote:
> Do we still want some CXXOPT flag for the server build? I can write a
> patch, but someone else would need to do the bikeshedding how to name
> it, and which of the existing knobs would set CXXFLAGS along. I don't
> think I need that feature.

If we don't directly need it, let's not add it now but let's revisit
the need if it proves necessary. I propose to just commit the last
patch you sent, and back-patch to ease integration with existing
extensions. Any objections?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jamison, Kirk 2019-01-31 00:59:46 RE: pg_upgrade: Pass -j down to vacuumdb
Previous Message Michael Paquier 2019-01-31 00:39:35 Re: backslash-dot quoting in COPY CSV