|From:||Andres Freund <andres(at)anarazel(dot)de>|
|To:||Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2019-01-29 16:18:46 +0100, Christoph Berg wrote:
> Re: Michael Paquier 2019-01-23 <20190123004722(dot)GE3873(at)paquier(dot)xyz>
> > >> Largely because I think it's an independent patch from the CXXOPT need
> > >> from Christopher / Debian packaging. It's a larger patch, that needs
> > >> more docs etc. If whoever applies that wants to backpatch it - I'm not
> > >> going to protest, I just wouldn't myself, unless somebody pipes up that
> > >> it'd help them.
> > >
> > > Ah, I see. No arguments against.
> Fwiw I'm not attached to using COPT and friends, I just happend to
> pick these because that was one way that worked. With what I've
> learned now, PG_*FLAGS is the better approach.
I'm confused - that doesn't allow to inject flags to all in-core built
files? So how does that fix your problem fully? Say
e.g. llvmjit_inline.cpp won't get the flag, and thus not be
|Next Message||Stephen Frost||2019-01-30 01:52:08||Re: ALTER SESSION|
|Previous Message||Kyotaro HORIGUCHI||2019-01-30 01:42:04||Re: [HACKERS] Restricting maximum keep segments by repslots|