| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, michael(at)paquier(dot)xyz, andres(at)anarazel(dot)de, petr(dot)jelinek(at)2ndquadrant(dot)com, pet(dot)slavov(at)gmail(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, petr(at)2ndquadrant(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #15114: logical decoding Segmentation fault |
| Date: | 2019-01-29 01:53:50 |
| Message-ID: | 20190129015350.GA4128278@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Looks good. I found no functional problems.
On Mon, Jan 28, 2019 at 10:32:16PM +0100, Peter Eisentraut wrote:
> The fix is to avoid the constant expressions simplification in
> RelationGetIndexAttrBitmap(), so that it becomes safe to call in these
> contexts. The constant expressions simplification comes from the
> calls to RelationGetIndexExpressions()/RelationGetIndexPredicate() via
> BuildIndexInfo(). But RelationGetIndexAttrBitmap() calling
> BuildIndexInfo() is overkill. The latter just takes pg_index catalog
> information, packs it into the IndexInfo structure, which former than
> just unpacks again and throws away.
s/former than/the former then/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2019-01-29 02:27:33 | BUG #15609: synchronous_commit=off insert performance regression with secondary indexes |
| Previous Message | Peter Eisentraut | 2019-01-28 21:32:16 | Re: BUG #15114: logical decoding Segmentation fault |