Re: pgsql: Allow generalized expression syntax for partition bounds

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Allow generalized expression syntax for partition bounds
Date: 2019-01-26 02:04:23
Message-ID: 20190126020423.GF6459@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Jan 25, 2019 at 10:37:22AM +0000, Peter Eisentraut wrote:
> Allow generalized expression syntax for partition bounds
>
> Previously, only literals were allowed. This change allows general
> expressions, including functions calls, which are evaluated at the
> time the DDL command is executed.
>
> Besides offering some more functionality, it simplifies the parser
> structures and removes some inconsistencies in how the literals were
> handled.

fulmar, magpie and treepie are unhappy after this commit, and all of
them have the same complaint related to the order consistency of
partitions showing up in psql:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=magpie&dt=2019-01-25%2011%3A04%3A07

Partition key: LIST (a)
-Partitions: part_1 FOR VALUES IN (1),
+Partitions: part_null FOR VALUES IN (NULL),
+ part_1 FOR VALUES IN (1),
part_2 FOR VALUES IN (2),
- part_3 FOR VALUES IN (3),
- part_null FOR VALUES IN (NULL)
+ part_3 FOR VALUES IN (3)
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-01-26 02:15:10 pgsql: Allow UNLISTEN in hot-standby mode.
Previous Message Michael Paquier 2019-01-26 01:47:06 pgsql: Simplify restriction handling of two-phase commit for temporary