| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | move hash_any to utils/hash/hashfn.c |
| Date: | 2019-01-25 19:35:18 |
| Message-ID: | 201901251935.ser5e4h6djt2@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I just noticed (once again) that we have hash_any() declared in
src/access/hash.h (the header file for the hash index AM) rather than
somewhere in utils/, for no good reason other than perhaps there was no
better place when it was introduced. This means that some files that
seem to just need hash_any end up pointlessly #including the whole AM
world upon themselves.
Would anybody object too hard if I move hash_any() and friends to
src/backend/utils/hash/hashfn.c and the declarations to
src/include/utils/hashutils.h?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-01-25 19:54:55 | Re: move hash_any to utils/hash/hashfn.c |
| Previous Message | 'Bruce Momjian' | 2019-01-25 19:13:21 | Re: Protect syscache from bloating with negative cache entries |