Re: Old protocol fastpath calls borked?

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Old protocol fastpath calls borked?
Date: 2019-01-24 22:11:11
Message-ID: 20190124221111.zwuu7epi3bgrnoky@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2019-01-24 17:04:32 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > In parse_fcall_arguments_20():
> > we appear to constantly setting argnull to true for all arguments?
>
> Uh, it looks to me like it does so only if the frontend sends a -1
> length field, which is the protocol's convention for indicating a
> null.

Ah, brainfade. Probably triggered by the fact that I forgot that we call
input functions even on NULL (which never quite made sense to me).

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-01-24 22:18:56 Re: Old protocol fastpath calls borked?
Previous Message Tom Lane 2019-01-24 22:08:45 Re: proposal - plpgsql unique statement id