Re: "ALTER TRIGGER .. RENAME TO" broken with the "Remove WITH OIDS" commit.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: "ALTER TRIGGER .. RENAME TO" broken with the "Remove WITH OIDS" commit.
Date: 2019-01-21 17:28:08
Message-ID: 20190121172808.wztidyesdjgxvseh@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2019-01-21 17:02:15 +0530, Rushabh Lathia wrote:
> Hi,
>
> I found that ALTER TRIGGER .. RENAME TO is broken and it's
> unable to rename the trigger. Looking further seems renametrig()
> function, copy the new trigger name into wrong tuple. This is
> broken with below commit:
>
> commit 578b229718e8f15fa779e20f086c4b6bb3776106
> Author: Andres Freund <andres(at)anarazel(dot)de>
> Date: Tue Nov 20 15:36:57 2018 -0800
>
> Remove WITH OIDS support, change oid catalog column visibility.
>
> PFA patch to fix the issue. I also added the testcase for the
> same into the regression.

Thanks for finding and the fix. Pushed!

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2019-01-21 17:39:26 Re: jsonpath
Previous Message Nishant, Fnu 2019-01-21 17:09:38 Re: possible deadlock: different lock ordering for heap pages