Re: pgsql: Restrict the use of temporary namespace in two-phase transaction

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Restrict the use of temporary namespace in two-phase transaction
Date: 2019-01-19 01:12:00
Message-ID: 20190119011200.GA3306@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Jan 19, 2019 at 09:08:27AM +0900, Michael Paquier wrote:
> On Fri, Jan 18, 2019 at 03:34:30PM -0500, Tom Lane wrote:
>> Seems hard to avoid. We could conceivably make it return "pg_temp"
>> for the temp schema instead of the schema's actual name, but it's
>> not very hard to think of ways whereby that would make use of the
>> result fail in contexts where it previously worked.
>
> CREATE EXTENSION is one such case. It would not work if referring to
> the synonym pg_temp, but it can work if using directly the temporary
> namespace of the session. So I feel that changing such things is
> prone to break more things than to actually fix things.

As long as I don't forget about it.. current_schema() is classified
as stable, so it's not like we can make it return pg_temp and then the
real temporary schema name within the same transaction...
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2019-01-19 08:51:10 pgsql: Fix outdated comment
Previous Message Michael Paquier 2019-01-19 00:08:27 Re: pgsql: Restrict the use of temporary namespace in two-phase transaction

Browse pgsql-hackers by date

  From Date Subject
Next Message Chapman Flack 2019-01-19 01:20:44 House style for DocBook documentation?
Previous Message andres@anarazel.de 2019-01-19 01:09:41 Re: Protect syscache from bloating with negative cache entries