From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
Subject: | Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead |
Date: | 2019-01-17 23:33:06 |
Message-ID: | 201901172333.c4x4ezrjh2ib@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
You introduced new macros IsHeapRelation and IsViewRelation, but I don't
want to introduce such API. Such things have been heavily contested and
I don't to have one more thing to worry about for this patch, so please
just put the relkind directly in the code.
On 2019-Jan-07, Nikolay Shaplov wrote:
> I also reworked some comments. BTW do you know what is this comments spoke
> about:
>
> * RelationGetFillFactor() and RelationGetTargetPageFreeSpace() can only
> * be applied to relations that use this format or a superset for
> * private options data.
>
> It is speaking about some old times when there can be some other type of
> options? 'cause I do not understand what it is speaking about.
> I've removed it, I hope I did not remove anything important.
As I understand it's talking about the varlenas being StdRdOptions and
not anything else. I think extensibility could cause some relkinds to
use different options.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2019-01-17 23:38:09 | Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages) |
Previous Message | Tom Lane | 2019-01-17 23:31:27 | Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD |