| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Maksim Milyutin <milyutinma(at)gmail(dot)com> |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Kevin Grittner <kgrittn(at)gmail(dot)com> |
| Subject: | Re: O_DIRECT for relations and SLRUs (Prototype) |
| Date: | 2019-01-16 01:54:28 |
| Message-ID: | 20190116015428.GK1433@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 15, 2019 at 07:40:12PM +0300, Maksim Milyutin wrote:
> Could you specify all cases when buffers will not be aligned with BLCKSZ?
>
> AFAIC shared and temp buffers are aligned. And what ones are not?
SLRU buffers are not aligned with the OS pages (aka alignment with
4096 at least). There are also a bunch of code paths where the callers
of mdread() or mdwrite() don't do that, which makes a correct patch
more invasive.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-01-16 02:02:08 | Bump up PG_CONTROL_VERSION on HEAD |
| Previous Message | Michael Paquier | 2019-01-16 01:48:24 | Re: Making WAL receiver startup rely on GUC context for primary_conninfo and primary_slot_name |