| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Reducing header interdependencies around heapam.h et al. |
| Date: | 2019-01-14 02:54:58 |
| Message-ID: | 201901140254.elpteegtbjmy@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Jan-13, Andres Freund wrote:
> Alvaro, you'd introduced the split of HeapScanDesc and HeapScanDescData
> being in different files (in a3540b0f657c6352) - what do you think about
> this change? I didn't revert that split, but I think we ought to
> consider just relying on a forward declared struct in heapam.h instead,
> this split is pretty confusing and seems to lead to more interdependence
> in a lot of cases.
I wasn't terribly happy with that split, so I'm not opposed to doing
things differently. For your consideration, I've had this patch lying
around for a few years, which (IIRC) reduces the exposure of heapam.h by
splitting relscan.h in two. This applies on top of dd778e9d8884 (and as
I recall it worked well there).
I'll try to have a look at your patch tomorrow.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-01-14 03:05:03 | Re: Reducing header interdependencies around heapam.h et al. |
| Previous Message | Chapman Flack | 2019-01-14 01:41:34 | Re: PostgreSQL vs SQL/XML Standards |