From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Banck <michael(dot)banck(at)credativ(dot)de>, Postgres Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Misleading panic message in backend/access/transam/xlog.c |
Date: | 2019-01-10 01:38:32 |
Message-ID: | 20190110013832.GE2157@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 09, 2019 at 05:09:19PM -0800, Andres Freund wrote:
> IIRC we have other such errors including offset and length (and if
> not we'll grow some). It should be formatted as a genetic write
> error with the file name, no reference to log file, etc, even if
> there's no precedent.
Yeah, there are a couple of them:
access/transam/xlog.c:
errmsg("could not read from log segment %s, offset %u: %m",
access/transam/xlog.c:
errmsg("could not read from log segment %s, offset %u: read %d of %zu",
access/transam/xlogutils.c:
errmsg("could not seek in log segment %s to offset %u: %m"
access/transam/xlogutils.c:
errmsg("could not read from log segment %s, offset %u, length %lu: %m",
replication/walreceiver.c:
errmsg("could not seek in log segment %s to offset %u: %m",
replication/walsender.c:
errmsg("could not seek in log segment %s to offset %u: %m",
replication/walsender.c:
errmsg("could not read from log segment %s, offset %u, length %zu: %m",
replication/walsender.c:
errmsg("could not read from log segment %s, offset %u: read %d of %zu",
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Donald Dong | 2019-01-10 01:38:53 | Re: Making WAL receiver startup rely on GUC context for primary_conninfo and primary_slot_name |
Previous Message | Andreas Karlsson | 2019-01-10 01:28:04 | Re: Early WIP/PoC for inlining CTEs |