Re: Misleading panic message in backend/access/transam/xlog.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Michael Banck <michael(dot)banck(at)credativ(dot)de>, Postgres Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Misleading panic message in backend/access/transam/xlog.c
Date: 2019-01-10 01:01:40
Message-ID: 20190110010140.GD2157@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 09, 2019 at 08:10:43AM -0800, Andres Freund wrote:
> I'm quite unenthused about that. If anything, I'd remove detail and use
> the standard error message about not being able to write to a file, and
> include the full path.

Partially agreed. Those messages have been left out of 56df07b
because they include some context about the offset and the length, and
I don't think that we simply want to remove that information. What
about making the offset and the length part of an extra errdetail, and
switch the main error string to a more generic one?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-01-10 01:09:19 Re: Misleading panic message in backend/access/transam/xlog.c
Previous Message Tom Lane 2019-01-10 00:48:01 pgsql: Use perfect hashing, instead of binary search, for keyword looku