| From: | Christoph Berg <christoph(dot)berg(at)credativ(dot)de> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well |
| Date: | 2019-01-08 08:09:56 |
| Message-ID: | 20190108080956.GH1582@msg.credativ.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Re: Andres Freund 2019-01-08 <20190108011837(dot)n4mx7dadvojv2x55(at)alap3(dot)anarazel(dot)de>
> > Here's another revision that doesn't add an extra CXXOPT variable but
> > just extends CXXFLAGS whenever COPT or PROFILE are set, which seems
> > more usable.
>
> Why does that seem more usable? How's that supposed to be used for flags
> that aren't valid for both languages?
The existing COPT and PROFILE are already catch-all type flags that
add to CFLAGS and LDFLAGS. Possibly we should leave those alone and
only add PG_CXXFLAGS and PG_LDFLAGS?
Christoph
--
Senior Berater, Tel.: +49 2166 9901 187
credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
Unser Umgang mit personenbezogenen Daten unterliegt
folgenden Bestimmungen: https://www.credativ.de/datenschutz
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-01-08 08:40:52 | Re: Undo logs |
| Previous Message | Haribabu Kommi | 2019-01-08 08:09:12 | Re: Displaying and dumping of table access methods |