| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Sender Address Forgery]Re: error message when subscription target is a partitioned table |
| Date: | 2019-01-08 04:44:22 |
| Message-ID: | 20190108044422.GL22498@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 08, 2019 at 01:13:11PM +0900, Amit Langote wrote:
> Yeah, I think so too. I also noticed that the patch uses
> ERRCODE_WRONG_OBJECT_TYPE as the error code, whereas we may want to use
> ERRCODE_FEATURE_NOT_SUPPORTED. Thoughts on that?
ERRCODE_WRONG_OBJECT_TYPE is the right call I think as the feature is
actually supported, just not for all the object types.
> Attached updated patch, which changes the detail message text as you
> suggest and updates the error code.
Another suggestion I would have is also to change the third message of
CheckSubscriptionRelkind() so as its style maps the two others you are
adding, as what's on HEAD is not a model of its kind with its
formulation using a full sentence.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-01-08 06:05:42 | Re: [Sender Address Forgery]Re: error message when subscription target is a partitioned table |
| Previous Message | Amit Langote | 2019-01-08 04:13:11 | Re: [Sender Address Forgery]Re: error message when subscription target is a partitioned table |