Re: Why not represent "never vacuumed" accurately wrt pg_class.relpages?

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why not represent "never vacuumed" accurately wrt pg_class.relpages?
Date: 2019-01-05 19:09:38
Message-ID: 20190105190937.GQ2528@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> On Tue, Dec 11, 2018 at 11:47 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Andres Freund <andres(at)anarazel(dot)de> writes:
> > > I don't quite get why we don't instead just represent "never vacuumed"
> > > by storing a more meaningful value in relpages?
> >
> > Mostly, not wanting to break clients that look at these fields.
> > If catalog compatibility weren't a concern, I'd seriously consider
> > replacing both of them with a float "average tuples per page" ratio.
>
> I think we should do exactly that thing.

On first blush, I tend to agree, but what I really wanted to remark here
is that I don't think we should be hand-tying ourselves as to what we
can do because we don't want to upset people who are reading the
catalogs. We make changes to the catalogs pretty regularly and while we
get complaints here and there, by and large, users are accustomed to
them and appreciate that we don't have a lot of baggage from trying to
support old interfaces and that we're able to make as much progress year
over year as we are.

Further, we support major releases for 5 years for a reason- users have
quite a bit of time to adjust to the changes.

> And I also agree that assuming 10 pages when pg_class says 0 and 1
> page when pg_class says 1 is not particularly bright.

Agreed.

Thanks!

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2019-01-05 19:15:00 Re: Record last password change
Previous Message Stephen Frost 2019-01-05 19:01:27 Re: Sketch of a fix for that truncation data corruption issue