Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
Date: 2019-01-04 13:33:05
Message-ID: 20190104133305.GG2067@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 04, 2019 at 11:41:15AM +0100, Peter Eisentraut wrote:
> Note that pgxs supports PG_CPPFLAGS for adding custom pieces to CPPFLAGS
> in a safe way. Maybe we should add an equivalent for CFLAGS? It's just
> that it hasn't been needed so far.

+1. Wouldn't it make sense to also have PG_LDFLAGS? In some stuff I
maintain, I have been abusing of PG_CPPFLAGS to pass some flags, which
is not really right. We also have contrib/passwordcheck/Makefile
abuse of it to set -DUSE_CRACKLIB..
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2019-01-04 13:45:55 Re: Allow auto_explain to log to NOTICE
Previous Message Greg Stark 2019-01-04 13:30:37 Re: Custom text type for title text