From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
Subject: | Re: Removing --disable-strong-random from the code |
Date: | 2018-12-30 07:15:49 |
Message-ID: | 20181230071549.GA2734@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Dec 30, 2018 at 01:45:42AM -0500, Tom Lane wrote:
> Hah, I was just about to work on that myself --- glad I didn't get
> to it quite yet. A couple of thoughts:
>
> 1. Surely there's documentation about --disable-strong-random
> to clean up too?
Oops, I forgot to grep on this one. Removed from my tree.
> 2. I wonder whether it's worth adding this to port.h:
>
> extern bool pg_strong_random(void *buf, size_t len);
> +/* pg_backend_random used to be a wrapper for pg_strong_random */
> +#define pg_backend_random pg_strong_random
>
> to prevent unnecessary breakage in extensions that might be depending
> on pg_backend_random.
Sure, that makes sense. Added.
> 3. Didn't look, but the MSVC build code might need a tweak too
> now that pg_strong_random.o is built-always rather than conditional?
There is nothing needed here as pg_strong_random.c has always been
included into @pgportfiles as we assumed that Windows would always
have a random source.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2018-12-30 07:35:52 | Re: plpgsql plugin - stmt_beg/end is not called for top level block of statements |
Previous Message | Tom Lane | 2018-12-30 06:45:42 | Re: Removing --disable-strong-random from the code |