| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Dimitri Fontaine <dimitri(at)citusdata(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Prepare Transaction support for ON COMMIT DROP temporary tables |
| Date: | 2018-12-28 23:32:30 |
| Message-ID: | 20181228233230.GD2972@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 28, 2018 at 08:32:15PM +0100, Dimitri Fontaine wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> I suggest to add in your regression tests a case where the prepared
>> transaction commits, and ensuring that the temp table is gone from
>> catalogs.
>
> Please find such a revision attached.
Being able to relax a bit the case is better than nothing, so that's
nice to see incremental improvements. Thanks Dimitri.
I just had a very quick glance, so that's far from being a detailed
review, but could it be possible to add test cases involving
inheritance trees and/or partitions if that makes sense? The ON
COMMIT action handling is designed to make such cases work properly.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-12-29 00:36:52 | Re: random() (was Re: New GUC to sample log queries) |
| Previous Message | Peter Geoghegan | 2018-12-28 23:32:26 | Re: Making all nbtree entries unique by having heap TIDs participate in comparisons |