Re: Poor buildfarm coverage of strong-random alternatives

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Subject: Re: Poor buildfarm coverage of strong-random alternatives
Date: 2018-12-27 23:00:03
Message-ID: 20181227230003.GB2196@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 27, 2018 at 03:56:52PM -0500, Tom Lane wrote:
> More urgently, what about the lack of --disable-strong-random
> coverage? I feel like we should either have a buildfarm
> critter or two testing that code, or decide that it's no longer
> interesting and rip it out. backend_random.c, to name just
> one place, has a complex enough !HAVE_STRONG_RANDOM code path
> that I don't feel comfortable letting it go totally untested.

If that proves to not be useful, just dropping the switch sounds like
a good option to me. I would be curious to hear Heikki on the matter
as he has introduced the switch in the v10 time-frame.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-12-27 23:14:03 Re: Poor buildfarm coverage of strong-random alternatives
Previous Message Tom Lane 2018-12-27 23:00:02 Re: random() (was Re: New GUC to sample log queries)