|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||Postgres hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Alvaro has cleaned up a couple of error messages recently so as they do
not include the function name in what gets translated as per 68f6f2b7.
While looking in the code for similar patterns, I have been reminded
that pg_stop_backup() is included in some messages when waiting for
segments to be archived. This has resulted in an exchange between Tom
and me here:
The thing is that the current messages are actually misleading, because
for base backups taken by the replication protocol pg_stop_backup is
never called, which is I think confusing. While looking around I have
also noticed that the top comments of do_pg_start_backup and
do_pg_stop_backup also that they are used with BASE_BACKUP.
Attached is a patch to reduce the confusion and improve the related
comments and messages.
|Next Message||Kyotaro HORIGUCHI||2018-12-21 04:49:18||Re: Change pgarch_readyXlog() to return .history files first|
|Previous Message||Tom Lane||2018-12-21 03:31:16||Re: Tid scan improvements|