Re: [PATCH] Improve tab completion for CREATE TABLE

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Improve tab completion for CREATE TABLE
Date: 2018-12-20 05:33:52
Message-ID: 20181220053352.GO27104@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 20, 2018 at 12:02:52AM +0000, Dagfinn Ilmari Mannsåker wrote:
> Point, fixed in the attached v4. OTOH, as I mentioned in my other
> email, that runs into the problem that it won't complete the actions
> after e.g. "CREATE TEMP TABLE FOO () WITH () ON COMMIT".

I am fine to do that later on if that's adapted, one complication being
that the completion is dependent on the order of the clauses for CREATE
TABLE as we need something compatible with CREATE TABLE commands bundled
with CREATE SCHEMA calls so only tail checks can be done.

So committed your last version after some comment tweaks and reordering
the entries in alphabetical order.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2018-12-20 05:53:23 Using POPCNT and other advanced bit manipulation instructions
Previous Message Tom Lane 2018-12-20 05:24:37 Re: slow queries over information schema.tables