Re: pgsql: Remove function names from error messages

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove function names from error messages
Date: 2018-12-20 01:21:45
Message-ID: 20181220012145.GG27104@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, Dec 19, 2018 at 07:42:31PM -0500, Tom Lane wrote:
> Those are at least reporting SQL function names that the user will
> recognize ... still, we don't normally localize error messages
> by the reporting function name, so I tend to agree that these are
> not following the style guide.

What do you think about something like the attached?
--
Michael

Attachment Content-Type Size
func-message-clean.patch text/x-diff 1.7 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Greg Stark 2018-12-20 02:01:03 pgsql: Fix ADD IF NOT EXISTS used in conjunction with ALTER TABLE ONLY
Previous Message Tom Lane 2018-12-20 00:42:31 Re: pgsql: Remove function names from error messages