Re: BUG #15548: Unaccent does not remove combining diacritical characters

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, hugh(at)whtc(dot)ca, daniel(at)manitou-mail(dot)org, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
Date: 2018-12-18 06:33:04
Message-ID: 20181218063304.GN1532@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Dec 18, 2018 at 01:23:57AM -0500, Tom Lane wrote:
> Maybe I'm misremembering, but I thought that discussion was about the
> code files. I am still mistrustful of non-ASCII in our code files.

Yes, that was in generate_unaccent_rules.py:
https://www.postgresql.org/message-id/25859.1535076450@sss.pgh.pa.us

> But for data and test files, we've been accepting UTF8 ever since the
> text-search-in-core stuff landed. Heck, unaccent.rules itself is UTF8.

Okay, fine by me.
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Etsuro Fujita 2018-12-18 12:48:59 Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction
Previous Message Tom Lane 2018-12-18 06:23:57 Re: BUG #15548: Unaccent does not remove combining diacritical characters

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Lepikhov 2018-12-18 06:52:50 Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)
Previous Message Michael Paquier 2018-12-18 06:26:27 Re: don't create storage when unnecessary