Re: Fixing typos in tests of partition_info.sql

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fixing typos in tests of partition_info.sql
Date: 2018-12-17 10:49:42
Message-ID: 20181217104942.GA2501@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 17, 2018 at 06:35:03PM +0900, Amit Langote wrote:
> As far as the information content of this comment is concerned, I think
> it'd be more useful to word this comment such that it is applicable to
> different functions than to word it such that it is applicable to
> different queries. More opinions would be nice.

This argument is sensible.

> Okay, how about:
>
> -- Various partitioning-related functions return NULL if passed relations
> -- of types that cannot be part of a partition tree; for example, views,
> -- materialized views, etc.

Okay, this suggestion sounds fine to me. Thanks!
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-12-17 11:36:10 Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query
Previous Message Surafel Temesgen 2018-12-17 10:29:29 Re: pg_dump multi VALUES INSERT