| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | amul sul <sulamul(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
| Subject: | Re: ALTER INDEX ... ALTER COLUMN not present in dump |
| Date: | 2018-12-17 07:34:19 |
| Message-ID: | 20181217073419.GC5223@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Mon, Dec 17, 2018 at 12:49:03PM +0530, amul sul wrote:
> On Mon, Dec 17, 2018 at 11:54 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> So this settles the argument that we had better not do anything before
>> v11. Switching the dump code to use column numbers has not proved to be
>> complicated as only the query and some comments had to be tweaked.
>> Attached is an updated patch, and I am switching back the patch to
>> "Needs review" to have an extra pair of eyes look at that in case I
>> missed something.
>
> This v4-patch needs a rebase against the latest master head(#67915fb).
I am on top of the master branch at 67915fb8, and this applies fine for
me:
$ patch -p1 < dump-alter-index-stats-v4.patch
patching file src/bin/pg_dump/pg_dump.c
patching file src/bin/pg_dump/pg_dump.h
patching file src/bin/pg_dump/t/002_pg_dump.pl
Thanks,
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | amul sul | 2018-12-17 07:49:00 | Re: ALTER INDEX ... ALTER COLUMN not present in dump |
| Previous Message | amul sul | 2018-12-17 07:19:03 | Re: ALTER INDEX ... ALTER COLUMN not present in dump |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-12-17 07:38:23 | Re: Fixing typos in tests of partition_info.sql |
| Previous Message | Amit Kapila | 2018-12-17 07:30:39 | Re: Remove double trailing semicolons |