Re: reorderbuffer: memory overconsumption with medium-size subxacts

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Subject: Re: reorderbuffer: memory overconsumption with medium-size subxacts
Date: 2018-12-16 20:30:30
Message-ID: 20181216203030.jo5nndymtiuykud6@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-Dec-16, Andres Freund wrote:

> > I think there's a one-line fix, attached: just add the number of changes
> > in a subxact to nentries_mem when the transaction is assigned to the
> > parent.
>
> Isn't this going to cause significant breakage, because we rely on
> nentries_mem to be accurate?
>
> /* try to load changes from disk */
> if (entry->txn->nentries != entry->txn->nentries_mem)

Bahh.

Are you suggesting I should try a more thorough rewrite of
reorderbuffer.c?

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-12-16 20:32:25 Re: reorderbuffer: memory overconsumption with medium-size subxacts
Previous Message David Rowley 2018-12-16 20:23:20 Remove double trailing semicolons