| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Takahashi, Ryohei" <r(dot)takahashi_2(at)jp(dot)fujitsu(dot)com> |
| Cc: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, 'Magnus Hagander' <magnus(at)hagander(dot)net>, 'Noah Misch' <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Too many logs are written on Windows (LOG: could not reserve shared memory region (addr=%p) for child %p:) |
| Date: | 2018-12-10 02:42:42 |
| Message-ID: | 20181210024242.GA1105@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 10, 2018 at 02:15:07AM +0000, Takahashi, Ryohei wrote:
>> We can change pgwin32_ReserveSharedMemoryRegion() to take an argument "int
>> loglevel". Then the caller first calls it with LOG, and DEBUGx afterwards.
>> It may also be helpful for the caller to output "LOG: tried %d times to
>> reserve shared memory region" when the caller ran the function twice or
>> more before success. That explains the possibly long time or CPU spikes
>> of connection establishment.
>
> It seems good idea for me.
Like a couple of others on this thread I doubt that lowering the elevel
here would be a good thing, as keeping it noisy has been what allows to
know that something has gone wrong, no? The current behavior is
useful.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2018-12-10 02:58:41 | Re: min_parallel_table_size and inheritence |
| Previous Message | Michael Paquier | 2018-12-10 02:22:09 | Re: Should new partitions inherit their tablespace from their parent? |