| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | John Naylor <jcnaylor(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: automatically assigning catalog toast oids |
| Date: | 2018-12-09 20:42:57 |
| Message-ID: | 20181209204257.GH3415@tamriel.snowman.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greetings,
* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> John Naylor <jcnaylor(at)gmail(dot)com> writes:
> > Commit 96cdeae07 added toast tables to most catalogs. One disadvantage
> > is that the toast declarations require hard-coded oids, even though
> > only shared catalogs actually need stable oids. Now that we can assign
> > oids on the fly, it makes sense to do so for toast tables as well, as
> > in the attached.
>
> I'm a bit dubious that this is a good idea. It's handy, at least for
> forensic situations, that the system catalogs have stable OIDs.
I tend to agree... What's the advantage of assigning them on the fly?
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-12-09 21:17:41 | Re: automatically assigning catalog toast oids |
| Previous Message | Andres Freund | 2018-12-09 20:04:53 | Re: Why does TupleDescInitBuiltinEntry lack a "default: error" case? |